New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(EZ-31) Add pre_start_action to start scripts #195
(EZ-31) Add pre_start_action to start scripts #195
Conversation
This the most exciting code review I've ever had. |
@dankreek have you tried using it for the rundir thingy thing? |
Do we have any post_start_actions that we need to account for that want to run as the service user? |
@shrug you mean because of PermissionsStartOnly=true ? |
Yes |
I've functionally reviewed this on Cent7 and it went well, I'm going to try it on Ubuntu 14.04 and Cent6 today. |
I'm 👍 and @shrug i'm not away of any post_start_actions that need to run as the service user. For sysv they are all running as root already anyway. |
Yeah, I was kind of wondering if we should maybe need a flag for "run post/pre stuff as root." It could easily be added later if needed. |
@dankreek because sysv pre and post stuff will always run as root, I'm not going to worry about it for a while. |
👍 |
@haus you want to push that button? |
(EZ-31) Add pre_start_action to start scripts
In order for the
install
command to work from a Puppet server build I needed to add thePermissionsStartOnly=true
line which instructs systemd to run theExecStartPre
commands as root before switching to the service user