Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(EZ-31) Add pre_start_action to start scripts #195

Merged

Conversation

dankreek
Copy link
Contributor

@dankreek dankreek commented Mar 6, 2015

In order for the install command to work from a Puppet server build I needed to add the PermissionsStartOnly=true line which instructs systemd to run the ExecStartPre commands as root before switching to the service user

@haus
Copy link
Contributor

haus commented Mar 6, 2015

@haus
Copy link
Contributor

haus commented Mar 6, 2015

@dankreek
Copy link
Contributor Author

dankreek commented Mar 6, 2015

This the most exciting code review I've ever had.

@haus
Copy link
Contributor

haus commented Mar 6, 2015

@dankreek have you tried using it for the rundir thingy thing?

@shrug
Copy link

shrug commented Mar 6, 2015

Do we have any post_start_actions that we need to account for that want to run as the service user?

@haus
Copy link
Contributor

haus commented Mar 6, 2015

@shrug you mean because of PermissionsStartOnly=true ?

@shrug
Copy link

shrug commented Mar 6, 2015

Yes

@dankreek
Copy link
Contributor Author

dankreek commented Mar 6, 2015

I've functionally reviewed this on Cent7 and it went well, I'm going to try it on Ubuntu 14.04 and Cent6 today.

@haus
Copy link
Contributor

haus commented Mar 6, 2015

I'm 👍 and @shrug i'm not away of any post_start_actions that need to run as the service user. For sysv they are all running as root already anyway.

@dankreek
Copy link
Contributor Author

dankreek commented Mar 6, 2015

Yeah, I was kind of wondering if we should maybe need a flag for "run post/pre stuff as root." It could easily be added later if needed.

@haus
Copy link
Contributor

haus commented Mar 6, 2015

@dankreek because sysv pre and post stuff will always run as root, I'm not going to worry about it for a while.

@shrug
Copy link

shrug commented Mar 6, 2015

👍

@dankreek
Copy link
Contributor Author

dankreek commented Mar 6, 2015

@haus you want to push that button?

haus added a commit that referenced this pull request Mar 6, 2015
(EZ-31) Add pre_start_action to start scripts
@haus haus merged commit 8ffba91 into puppetlabs:master Mar 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants