(FACT-2589) fix RSpec warnings (#490)

* (FACT-2589) fix RSpec warnings
* (FACT-2589) remove empty before hook

spec/custom_facts/core/aggregate_spec.rb

@@ -38,7 +38,7 @@
     end
 
     it 'fact_type does not raise error' do
-      expect { aggregate_res.options(fact_type: 'custom') }.not_to raise_error(ArgumentError)
+      expect { aggregate_res.options(fact_type: 'custom') }.not_to raise_error
     end
   end
 

spec/custom_facts/util/parser_spec.rb

@@ -54,7 +54,7 @@
   shared_examples_for 'handling a not readable file' do
     before do
       allow(Facter::Util::FileHelper).to receive(:safe_read).with(data_file, nil).and_return(nil)
-      allow(LegacyFacter).to receive(:warn).at_least(:one)
+      allow(Facter).to receive(:log_exception).at_least(:once)
     end
 
     it 'handles not readable file' do
@@ -72,11 +72,10 @@
       expect(LegacyFacter::Util::Parser.parser_for(data_file).results).to eq data
     end
 
-    it 'handles exceptions and warn' do
-      # YAML data with an error
+    it 'handles exceptions' do
       allow(Facter::Util::FileHelper).to receive(:safe_read)
         .with(data_file, nil).and_return(data_in_yaml + '}')
-      allow(LegacyFacter).to receive(:warn).at_least(:one)
+      allow(Facter).to receive(:log_exception).at_least(:once)
 
       expect { LegacyFacter::Util::Parser.parser_for(data_file).results }.not_to raise_error
     end

spec/custom_facts/util/resolution_spec.rb

@@ -102,7 +102,7 @@
     end
 
     it 'fact_type does not raise error' do
-      expect { resolution.options(fact_type: 'simple') }.not_to raise_error(ArgumentError)
+      expect { resolution.options(fact_type: 'simple') }.not_to raise_error
     end
 
     it 'fails on unhandled options' do

spec/facter/resolvers/solaris/current_zone_resolver_spec.rb

@@ -8,7 +8,6 @@
       .and_return(true)
     allow(Open3).to receive(:capture2)
       .with('/bin/zonename')
-      .ordered
       .and_return([zone_name_output, status])
   end
 

spec/facter/resolvers/solaris/zfs_resolver_spec.rb

@@ -5,7 +5,6 @@
     status = double(Process::Status, to_s: st)
     allow(Open3).to receive(:capture2)
       .with('zfs upgrade -v')
-      .ordered
       .and_return([output, status])
   end
 

spec/facter/resolvers/solaris/zone_resolver_spec.rb

@@ -8,7 +8,6 @@
       .and_return(true)
     allow(Open3).to receive(:capture2)
       .with('/usr/sbin/zoneadm list -cp')
-      .ordered
       .and_return([output, status])
   end
 

spec/facter/resolvers/solaris/zpool_resolver_spec.rb

@@ -5,7 +5,6 @@
     status = double(Process::Status, to_s: st)
     allow(Open3).to receive(:capture2)
       .with('zpool upgrade -v')
-      .ordered
       .and_return([output, status])
   end