Skip to content
This repository has been archived by the owner on Jun 19, 2020. It is now read-only.

(FACT-2542) Refactored unit tests for facter.rb #444

Closed
wants to merge 15 commits into from
Closed

(FACT-2542) Refactored unit tests for facter.rb #444

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e5e14ba
(FACT-2542) Fix typo
Apr 8, 2020
200c799
(FACT-2542) Refactored some tests
Apr 12, 2020
d54ffb8
(FACT-2542) Finished example refactoring
Apr 13, 2020
95ac37d
Merge branch 'master' into FACT-2542
Apr 13, 2020
8f092a0
(FACT-2542) Fixed rubocop offenses and a failing test
Apr 13, 2020
f5e6c62
(FACT-2545) merged master
Apr 22, 2020
fb9d4a1
(FACT-2559) Fix Facter.debugging? call when Facter not fully loaded (…
Filipovici-Andrei Apr 24, 2020
fa4638b
(FACT-2564) Add support for zpool_featureflags and fix zpool_version …
smortex Apr 24, 2020
3dd800c
(FACT-2553) remove double backslashes from path (#456)
oanatmaria Apr 24, 2020
0406682
(FACT-2552) Add Solaris processors facts (#451)
oanatmaria Apr 24, 2020
936fa51
(Fact 2486) Add facts cache (#430)
florindragos Apr 24, 2020
d3e574d
(FACT-2565) Debian development versions causes fatal error when resol…
Filipovici-Andrei Apr 24, 2020
58e1f83
(FACT-2542) fixed rubocop offenses
Apr 28, 2020
8d1253f
(maint) Remove rubycritic from CI (#474)
Apr 28, 2020
f32fc2f
(FACT-2555)Create OS hierarchy and mechanism for loading it (#470)
Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/facts/debian/os/distro/codename.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ class Codename

def call_the_resolver
fact_value = Facter::Resolvers::OsRelease.resolve(:version_codename)
fact_value ||= retreieve_from_version
fact_value ||= retrieve_from_version

Facter::ResolvedFact.new(FACT_NAME, fact_value)
end

def retreieve_from_version
def retrieve_from_version
version = Facter::Resolvers::OsRelease.resolve(:version)
return unless version

Expand Down
Loading