This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
(FACT-2552) Add Solaris processors facts #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oanatmaria
force-pushed
the
FACT-2552
branch
2 times, most recently
from
83f7282
to
a4d61ec
Compare
lib/facts_utils/converter.rb
Outdated
| format('%<displayed_speed>.2f', displayed_speed: validated_speed).to_s + ' ' + prefix[power] + 'Hz' | ||
| end | ||
|
|
||
| def bytes_to_human_readable(bytes) |
There was a problem hiding this comment.
I would remove _readable, it's as clear even without it.
There was a problem hiding this comment.
I kept the _readable because i think it is easier to understand what that method is supposed to do.
sebastian-miclea
previously approved these changes
Apr 21, 2020
BogdanIrimie
approved these changes
Apr 24, 2020
Filipovici-Andrei
pushed a commit
that referenced
this pull request
Apr 28, 2020
* (FACT-2552) Add Solaris processors facts * (FACT-2552) Fix rspec failure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Added solaris processors facts that were retrieved with kstat command. Bringing all methods that converts (bytes to mb, bytes to human readable, to hz) into one class.