This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
(FACT-2555)Create OS hierarchy and mechanism for loading it #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
April 15, 2020 10:45
… message instead of an error message.
gimmyxd
reviewed
Apr 28, 2020
added 2 commits
April 28, 2020 12:02
…me cases (e.g. when time machine is running on macOS)
Filipovici-Andrei
suggested changes
Apr 28, 2020
| RbConfig::CONFIG['host_os'] = 'my_custom_os' | ||
| end | ||
|
|
||
| it 'raise error if it could not detect os' do |
There was a problem hiding this comment.
an extra s at raise
added 5 commits
April 28, 2020 14:27
…termediary and root nodes.
Filipovici-Andrei
previously approved these changes
Apr 28, 2020
This reverts commit 0b220cd.
added 2 commits
April 28, 2020 16:06
gimmyxd
approved these changes
Apr 28, 2020
Filipovici-Andrei
pushed a commit
that referenced
this pull request
Apr 28, 2020
* (FACT-2555) If no module with the OS name was discovered, log a debug message instead of an error message. * (FACT-2555) Add OsHierarchy Class and json with Os hierarchy definition. * (FACT-2555) Reproduce existing hierarchy in os_hierarchy.json * (FACT-2555) Use OsHierarchy in OsDetector. Rubocop fixes. * (FACT-2555) If the distribution cannot be detected, default to linux * (FACT-2555) Add comments. * (FACT-2555) Add mock for OsHierarchy in OsDetector tests. * (FACT-2555) Add test for fallback to linux in case no distribution is detected. * (FACT-2555) Refactor OsDetector tests. * (FACT-2555) Try to use family to detect os placement in hierarchy. * (FACT-2555) Add mechanism for using os family if no hierarchy can be detected for OS. * (FACT-2555) Add tests for os_hierarchy. * (FACT-2555) Small refactoring of os detector. * (FACT-2555) Add test for family. * (FACT-2555) Force mount-point data to UTF-8 as it might be ASCI in some cases (e.g. when time machine is running on macOS) * (FACT-2555) Move conversion to UTF-8 in helper. * (FACT-2555) Add test for filesusyem_helper. Fix existing tests. * (FACT-2555) Fix os hierarchy for intermediary nodes. Add tests for intermediary and root nodes. * (FACT-2555) Address PR comments. * (FACT-2555) Move the action we are testing in the block. * (FACT-2555) Improve error handling for os_hierarchy. * Revert "(FACT-2555) Add test for filesusyem_helper. Fix existing tests." This reverts commit 0b220cd. * Revert "(FACT-2555) Move conversion to UTF-8 in helper." This reverts commit a218ac7. * Revert "(FACT-2555) Force mount-point data to UTF-8 as it might be ASCI in some cases (e.g. when time machine is running on macOS)" This reverts commit 8cdf10d. * (FACT-2555) Add test for cases that throw exceptions.
This was referenced Apr 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.