(FACT-1115) Fix execution of non-zero command exit treated as failure. #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA signed by all contributors. |
peterhuene
force-pushed
the
fact/1115
branch
2 times, most recently
from
f7967f4
to
a59f67f
Compare
Facter 2.x returns output from `Facter::Core::Execution::exec/execute` even if the command failed (non-zero exit code). It returned the value of the `on_fail` option only if the command couldn't be found. Facter 3 was returning the `on_fail` option if the command returned a non-zero exit code or couldn't be found. This commit restores the 2.x behavior.
MikaelSmith
pushed a commit
that referenced
this pull request
Jul 13, 2015
(FACT-1115) Fix execution of non-zero command exit treated as failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facter 2.x returns output from
Facter::Core::Execution::exec/executeeven if the command failed (non-zero exit code). It returned the value
of the
on_failoption only if the command couldn't be found.Facter 3 was returning the
on_failoption if the command returned anon-zero exit code or couldn't be found. This commit restores the 2.x
behavior.