Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(FACT-1118) Add 'noatime' option to mountpoint fact #1044

Merged
merged 1 commit into from Jul 16, 2015
Merged

(FACT-1118) Add 'noatime' option to mountpoint fact #1044

merged 1 commit into from Jul 16, 2015

Conversation

jasperla
Copy link

No description provided.

@puppetcla
Copy link

CLA signed by all contributors.

@MikaelSmith
Copy link

Can you add a short description of why this is needed in the commit message?

@jasperla
(FACT-1118) Add 'noatime' option to mountpoint fact
39241d9 
This makes it visible when a filesystem is mounted 'noatime'.
@jasperla
Copy link
Author

Like this? It's not strictly needed for anything, but since it's supported on the operating system level, we might as well display it to the user too, no?

@MikaelSmith
Copy link

@peterhuene why did we leave it off previously?

@peterhuene
Copy link

Appears to be an oversight.

@MikaelSmith
Copy link

👍 for merging then.

@peterhuene
Copy link

It seems we're missing MNT_CPROTECT, MNT_QUARANTINE, MNT_IGNORE_OWNERSHIP, MNT_NOUSERXATTR, and MNT_MULTILABEL on OSX too.

@jasperla
Copy link
Author

@peterhuene could you please handle that? I don't have an OSX machine around to test that; though I could cook up the patch if you like.

@peterhuene
Copy link

I assume that the above are all OSX specific?

@jasperla
Copy link
Author

@peterhuene it certainly seems like that; at least I cannot find them on OpenBSD or FreeBSD.

MikaelSmith pushed a commit that referenced this pull request Jul 16, 2015
Merge pull request #1044 from jasperla/mountpoints/noatime
3b1029a 
(FACT-1118) Add 'noatime' option to mountpoint fact
@MikaelSmith MikaelSmith merged commit 3b1029a into puppetlabs:master Jul 16, 2015
@MikaelSmith
Copy link

I'll file a ticket for the OSX specific flags.

@jasperla jasperla deleted the mountpoints/noatime branch July 18, 2015 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jasperla @puppetcla @MikaelSmith @peterhuene @joshcooper