(maint) refactor acceptance rakefile and options files #1094
Conversation
|
I just tried |
|
thanks @MikaelSmith. didn't realize i had removed that. probably should be deprecated to match beaker's option deprecation. |
|
👍 this looks ok to me. |
|
I'd vote for some more feedback before merging. |
|
yes, please. @joshcooper if you get a chance, some perspective on this would be great. i'm going to PR something similar against puppet and hiera after this goes through. the main functionality removed here was to manage hosts for the past 24hours. this functionality did not work with new versions of puppet. |
|
Needs a rebase now. |
|
@MikaelSmith done. |
|
Needs a rebase, and @joshcooper did you have any input? |
| File.open(preserved_config_path, 'r') do |file| | ||
| if file.ctime > yesterday | ||
| file.each_line do |line| | ||
| matchdata = /(\w+\.delivery\.puppetlabs\.net) \(.*?\)$/.match(line.encode!('UTF-8', 'UTF-8', :invalid => :replace)) |
There was a problem hiding this comment.
I would expect the hostname to be US_ASCII, can we drop the encode?
There was a problem hiding this comment.
inherited... i forget if this even works.
i can certainly remove the encode.
most of this functionality can/should move to beaker/vmpooler API.
which leads me to investigating a rakefile gem for at least puppet/facter/hiera, and i'd love to jettison the acceptance Rakefile altogether as in other projects.... but i digress
|
@MikaelSmith done. |
|
@er0ck @MikaelSmith It's been six weeks with no activity. Should this be rebased/resurected post-agent-1.3.0? |
|
yeah... i'll refactor this and address josh's concerns this week |
This change contains many changes to the acceptance Rakefile to put most of the options back in the options files and use new beaker features for creating preserved_hosts files. It removes some of the functionality in parsing log files, but this was all broken by beaker changes anyway. [skip ci]
|
@MikaelSmith rebased and ready to go. |
|
👍 on deleting code. I'll try it out and make sure some workflows still work. |
|
This looks ok. I say merge it and see who yells. On a side note, maybe we should remove the |
|
good idea removing the package options for sure. i don't think we have packages? |
|
Agreed on all counts. Let it rip and see what falls out. Including +1 on removing git/package, since they're bitrotted/obsolete at this point. |
…rakefile_options_files (maint) refactor acceptance rakefile and options files
|
FYI, passed in CI after the merge. |
This change contains many changes to the acceptance Rakefile to put most
of the options back in the options files and use new beaker features for
creating preserved_hosts files.
It removes some of the functionality in parsing log files, but this was
all broken by beaker changes anyway. If people need this we can add it back in at that
time.
[skip ci]