(FACT-1267) Fix os.macosx.version.full for .0 releases and update test #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 4, 2015 13:39
On OS X 10.y.0 releases, sw_vers reports the version as 10.y. Facter 3 would report this as the full version, rather than retaining Facter 2's munging of the version to add `.0`. Restore version munging to report 10.y.0.
Previously the acceptance test confirming platform facts would skip 10.11, and other unknown 10.x platforms. Update the test for 10.11 and ensure it fails on new platforms that it hasn't been updated for.
|
I've tested both changes independently and believe this will work. |
MikaelSmith
force-pushed
the
FACT-1267
branch
from
7f01f85
to
240bed5
Compare
|
Passed CI. |
joshcooper
added a commit
that referenced
this pull request
Nov 5, 2015
(FACT-1267) Fix os.macosx.version.full for .0 releases and update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.