(maint) Fix Git in PATH for AppVeyor #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AppVeyor started using 64-bit Git, which adds `Git\bin` or `Git\usr\bin` to the PATH (possibly both). Fix them both to use `Git\cmd` instead to avoid having `sh.exe` in the PATH.
|
Needed for #1230. |
|
LGTM. Should wait for appveyor to finish? |
|
Please don't merge to stable until we release today. Thanks!! |
|
Thanks for the heads up @kylog |
ferventcoder
changed the title
ferventcoder
changed the title
|
Merge to stable open? |
|
Yes, merging. |
kylog
pushed a commit
that referenced
this pull request
Nov 30, 2015
(maint) Fix Git in PATH for AppVeyor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppVeyor started using 64-bit Git, which adds
Git\binorGit\usr\binto the PATH (possibly both). Fix them both to use
Git\cmdinstead toavoid having
sh.exein the PATH.