Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FACT-1293) Add Arista Support #1249

Merged
merged 1 commit into from
Jan 6, 2016
Merged

(FACT-1293) Add Arista Support #1249

merged 1 commit into from
Jan 6, 2016

Conversation

LuvCurves
Copy link

No description provided.

@joshcooper
Copy link
Contributor

I think maybe the arista setup step is missing from this commit?

@LuvCurves
Copy link
Author

@joshcooper Yes, this is why the CI is failing

@joshcooper
Copy link
Contributor

Sorry what I mean is do you need to git add acceptance/setup/aio/pre-suite/021_InstallAristaModule.rb and amend this PR? As right now the PR refers to a non-existent file.

@LuvCurves
Copy link
Author

@joshcooper Got it. Corrected.

masters.each do |node|
on(node, puppet('module','install','aristanetworks-netdev_stdlib_eos'))
end
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment about facter acceptance doesn't have a master, and whether select_hosts will return nil or an empty array? If it's empty array, then this seems fine, if not, it will raise when we try to call nil.each

@waynr
Copy link

waynr commented Jan 6, 2016

👍

joshcooper added a commit that referenced this pull request Jan 6, 2016
@joshcooper joshcooper merged commit b7a0cd4 into puppetlabs:stable Jan 6, 2016
@joshcooper
Copy link
Contributor

$ bundle exec rake ci:test:aio TEST_TARGET=arista4-32a SUITE_VERSION=1.3.2.164.gb9b44ea SHA=b9b44eab32118af58c4d8bd97d0e57451f32534e
...
qpfz18rjcmdsr4q.delivery.puppetlabs.net (arista4-32-1) executed in 0.04 seconds
tests/options/yaml.rb passed in 0.75 seconds
      Test Suite: tests @ 2016-01-06 14:00:11 -0800

      - Host Configuration Summary -


              - Test Case Summary for suite 'tests' -
       Total Suite Time: 24.76 seconds
      Average Test Time: 0.77 seconds
              Attempted: 32
                 Passed: 22
                 Failed: 0
                Errored: 0
                Skipped: 10
                Pending: 0
                  Total: 32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants