-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(FACT-1293) Add Arista Support #1249
Conversation
I think maybe the arista setup step is missing from this commit? |
@joshcooper Yes, this is why the CI is failing |
Sorry what I mean is do you need to |
@joshcooper Got it. Corrected. |
masters.each do |node| | ||
on(node, puppet('module','install','aristanetworks-netdev_stdlib_eos')) | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar comment about facter acceptance doesn't have a master, and whether select_hosts
will return nil or an empty array? If it's empty array, then this seems fine, if not, it will raise when we try to call nil.each
👍 |
(FACT-1293) Add Arista Support
|
No description provided.