(FACT-1317) Fix YAML output of non-numeric types #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge after release |
MikaelSmith
force-pushed
the
FACT-1317
branch
from
92764ed
to
4b22dd4
Compare
MikaelSmith
changed the title
| bool has_separator = false; | ||
| // Note: Ruby YAML interprets 1,2,3 as a number, but not 1.2.3. | ||
| // It doesn't appear to honor locales when parsing YAML. | ||
| bool has_dot = false; | ||
| for (size_t i = 0; i < str.size(); ++i) { |
There was a problem hiding this comment.
any reason why this isn't for(char c: str) ?
EDIT: white line, this is just how it was before. No need to change it in this PR unless you really want to
There was a problem hiding this comment.
Update; i is used to check if it's the first character.
Several formats intended to be non-numeric are interpreted as numbers in (Ruby) YAML. Mac and IPv6 addresses as sexagesimal types: 10:10:10:10:10:10:10:10 01:23:45:54:32:21 Comma-delimited lists as comma-delimited integers: 1,2,3,4,5 123,456 Modify YAML quoting to ensure these patterns are quoted.
MikaelSmith
force-pushed
the
FACT-1317
branch
from
4b22dd4
to
812fac7
Compare
|
Updated. |
joshcooper
added a commit
that referenced
this pull request
Feb 5, 2016
(FACT-1317) Fix YAML output of non-numeric types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several formats intended to be non-numeric are interpreted as numbers in
(Ruby) YAML.
Mac and IPv6 addresses as sexagesimal types:
10:10:10:10:10:10:10:10
01:23:45:54:32:21
Comma-delimited lists as comma-delimited integers:
1,2,3,4,5
123,456
Modify YAML quoting to ensure these patterns are quoted.