(FACT-1338) Resolve weird pthread dependencies #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AIX shows a dependency on `.pthread_cancel` from `libboost_date_time`, which is now included in linking the `facter` binary from `leatherman_util`. Other links succeed because they include `libboost_thread`, bringing in a dependency on pthread. Explicitly depend on pthread everywhere until LTH-81 is resolved. Resolving LTH-81 exposes an implicit dependency of `libboost_date_time` and `libboost_regex` on pthread on some platforms that's not fulfilled by `find_package(Boost)`, so the libfacter and libfacter_test dependencies on pthread will be permanent.
|
Resolves AIX builds @johnduarte. I believe this started happening when we switched to doing shared library builds of Leatherman. /cc @branan |
|
👍 @branan can you provide a technical review here? |
peterhuene
added a commit
that referenced
this pull request
Feb 2, 2016
(FACT-1338) Resolve weird pthread dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AIX shows a dependency on
.pthread_cancelfromlibboost_date_time,which is now included in linking the
facterbinary fromleatherman_util. Other links succeed because they includelibboost_thread, bringing in a dependency on pthread.Explicitly depend on pthread everywhere until LTH-81 is resolved.
Resolving LTH-81 exposes an implicit dependency of
libboost_date_timeand
libboost_regexon pthread on some platforms that's not fulfilledby
find_package(Boost), so the libfacter and libfacter_testdependencies on pthread will be permanent.