(FACT-1317) Fix string values that look like booleans #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YAML will read boolean strings as boolean types. When the schema states the Fact type is a string, we should ensure it's read as a string by YAML parsers. Quote any boolean literal representation in a string_value. Also fix a prior mistake in the verify_facts acceptance test, which no longer needs to check for boolean classes for a string.
|
/cc @johnduarte |
|
👍 will merge after travis run |
johnduarte
pushed a commit
that referenced
this pull request
Feb 10, 2016
(FACT-1317) Fix string values that look like booleans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YAML will read boolean strings as boolean types. When the schema states
the Fact type is a string, we should ensure it's read as a string by
YAML parsers. Quote any boolean literal representation in a
string_value.
Also fix a prior mistake in the verify_facts acceptance test, which no
longer needs to check for boolean classes for a string.