(FACT-1375) Only recognize default route with netmask of 0.0.0.0 #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch, Facter will recognize any route with a destination of 0.0.0.0 as a default route, even if that route has a non-0 netmask. The default route always has a netmask of 0.0.0.0, and should be the one chosen to determine the primary network interface.
| @@ -81,7 +81,8 @@ namespace facter { namespace facts { namespace linux { | |||
| lth_file::each_line("/proc/net/route", [&interface](string& line) { | |||
| vector<boost::iterator_range<string::iterator>> parts; | |||
| boost::split(parts, line, boost::is_space(), boost::token_compress_on); | |||
| if (parts.size() > 1 && parts[1] == boost::as_literal("00000000")) { | |||
| if (parts.size() > 1 && parts[1] == boost::as_literal("00000000") | |||
There was a problem hiding this comment.
The size check needs to be updated in case the split didn't have 8 parts.
There was a problem hiding this comment.
Whoops, fixed. Sorry about that; it's been a very long time since I've done non-scripting-language programming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, Facter will recognize any route with a destination
of 0.0.0.0 as a default route, even if that route has a non-0 netmask.
The default route always has a netmask of 0.0.0.0, and should be the
one chosen to determine the primary network interface.