(FACT-1373) Prevent fact calls from external facts #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| environment::get("INSIDE_FACTER", inside_facter); | ||
|
|
||
| if (inside_facter == "true") { | ||
| LOG_WARNING("Facter was called recursively, skipping external facts. Add '--no-external-facts' to silence this warning"); |
There was a problem hiding this comment.
It might be worth mentioning that we detected this because INSIDE_FACTER was set to true, in case (somehow) someone accidentally has that in their environment. Or maybe we should just document that somewhere.
|
CLA signed by all contributors. |
HAIL9000
force-pushed
the
issue/master/FACT-1373_prevent_external_fact_fork_bomb
branch
from
9f03658
to
31ca619
Compare
Prior to this commit, it was possible to make a facter call from within an external fact. This would result in a fork bomb where facter would be constantly calling into itself. In order to prevent this, set an environment variable that allows us to ensure facter is not already running when we make the call to evaluate external facts.
HAIL9000
force-pushed
the
issue/master/FACT-1373_prevent_external_fact_fork_bomb
branch
from
31ca619
to
9b104fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, it was possible to make a facter call from
within an external fact. This would result in a fork bomb where
facter would be constantly calling into itself. In order to prevent
this, set an environment variable that allows us to ensure facter
is not already running when we make the call to evaluate external
facts.