Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(FACT-1712) Improve zpool_version fact resolution #1597

Merged
merged 2 commits into from
Jul 24, 2017
Merged

(FACT-1712) Improve zpool_version fact resolution #1597

merged 2 commits into from
Jul 24, 2017

Commits on Jul 24, 2017

  1. (FACT-1712) Rename ZFS / zpool related variables 

    ZFS and zpool versions are called "features" internaly, which will lead
us to a lot of confusion with newer versions of zpool havind a new
concept of feature flags.

Rename all these variables to prevent such confusion, but do not change
the fact names (zfs_featurenumbers, zpool_featurenumbers) for now to
avoid breaking thigs.
    @smortex
    smortex committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    891d2cf View commit details
    Browse the repository at this point in the history

  2. (FACT-1712) Add new zpool_featureflags fact 

    Extend zpool facts with feature flags on supported systems.

If feature flags are enabled, make the zpool_version flag return "1000"
as per [2].

References:
  1. http://www.open-zfs.org/wiki/Feature_Flags
  2. http://web.archive.org/web/20160419064650/http://blog.delphix.com/csiden/files/2012/01/ZFS_Feature_Flags.pdf
    @smortex
    smortex committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    b67d888 View commit details
    Browse the repository at this point in the history