(PA-2183) Update acceptance tests to work with Beaker 4 #1755
Conversation
|
CLA signed by all contributors. |
Previously, the facter tests asserted that any EL derivative must have at least one `.` in its version number. This is incorrect for amzl2, which reports its version simple as "2".
ekinanp
force-pushed
the
PA-2183-3.6.x
branch
from
b0113aa
to
e3bf6c3
Compare
|
This is blocked on voxpupuli/beaker#1551, puppetlabs/beaker-puppet#77, and a beaker + beaker-puppet release. |
|
https://jenkins-master-prod-1.delivery.puppetlabs.net/view/__experimental/job/experimental_puppet-agent-extra_puppet-agent-integration-suite_adhoc-1.10.x/2/ shows a passing ad-hoc build, so this is good to go if the CI failures can be ignored. |
|
Going to target this at 3.11.x instead. |
|
Do you want to add the (maint) tag so Travis passes? |
ekinanp
force-pushed
the
PA-2183-3.6.x
branch
from
e3bf6c3
to
cb1c58d
Compare
ekinanp
changed the title
|
I added the (maint) tag |
|
Is that a (maint) commit or a (PA-2183) commit? I don't get why we need both prefixes. |
|
To stop Travis from complaining about commit messages formatting.
Sent from miXs
… On Oct 30, 2018, at 12:44, smcclellan ***@***.***> wrote:
Is that a (maint) commit or a (PA-2183) commit? I don't get why we need both prefixes.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@smcclellan Because Facter requires commits to either have (maint) or (FACT-<ticket_no>) prefixed to them. It's really a PA-2183 commit, the (maint) is to get CI to pass. I'm happy to remove (maint) if we're ok merging it w/ CI failing, should be fine since it's just acceptance tests. |
ekinanp
force-pushed
the
PA-2183-3.6.x
branch
from
cb1c58d
to
9827b20
Compare
ekinanp
changed the title
|
I removed the maint commit title as it is misleading (this work does have a ticket), and the work is small enough that it is not worth creating an extra FACT ticket for it. Travis' commit checker can fail for this one. |
|
I'd love to just fix Travis' commit checker. I can think of plenty of cases where we'd want to merge non-FACT tickets into facter (such as this one). |
No description provided.