(FACT-3434) Accept ffi >= 1.16.3, < 1.17.0 #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffi 1.16.0 - 1.16.2 had a bug when defining a layout in an FFI::Struct and it
was fixed in 1.16.3[1]:
ERROR -- : Facter::InternalFactManager - can't modify frozen Hash: \
{:void=>#<FFI::Type::Builtin::VOID...
However, we can't require a minimum version of 1.16.3, because facter is
required by puppet, which also has a strict ffi requirement on '1.15.5'.
So in order to gradually update, facter needs to accept the range from 1.15.5 to
1.17.0, but exclude the problematic ffi versions.
[1] ffi/ffi#1056
joshcooper
added a commit
to joshcooper/puppet
that referenced
this pull request
Apr 25, 2024
ffi 1.16.0 - 1.16.2 had a bug when defining a layout in an FFI::Struct and it was fixed in 1.16.3. See puppetlabs/facter#2707
This was referenced Apr 25, 2024
mhashizume
approved these changes
Apr 25, 2024
AriaXLi
pushed a commit
to AriaXLi/puppet
that referenced
this pull request
May 9, 2024
ffi 1.16.0 - 1.16.2 had a bug when defining a layout in an FFI::Struct and it was fixed in 1.16.3. See puppetlabs/facter#2707 (cherry picked from commit aa51340)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ffi 1.16.0 - 1.16.2 had a bug when defining a layout in an FFI::Struct and it
was fixed in 1.16.3[1]:
However, we can't require a minimum version of 1.16.3, because facter is
required by puppet, which also has a strict ffi requirement on '1.15.5'.
So in order to gradually update, facter needs to accept the range from 1.15.5 to
1.17.0, but exclude the problematic ffi versions.
[1] ffi/ffi#1056