(#22349) Read from user's home when non-root #531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The external facts directory always assumed that the user was root, or at least had read access to the global facts.d directory. This created problems for users with restricted permissions when running as non-root. Instead of trying to handle the permissions problem, which would have made facter run, this changes facter to follow the same non-root style as puppet, which is to look in the home directory for a .facter/facts.d external facts directory. Simply handling the error would have had two undesirable consequences: 1) it would have hidden a problem from the user and 2) it would have made external facts cumbersome to use as non-root as the user would always have to specify --external-dir, which is not currently possible when facter is used by puppet.
|
CLA signed by all contributors. |
| end | ||
| end | ||
| end | ||
|
|
||
| if Facter::Util::Config.is_windows? | ||
| require 'rubygems' | ||
| require 'win32/dir' |
There was a problem hiding this comment.
You'll also need:
require 'windows/system_info' require 'windows/security' require 'sys/admin'
There was a problem hiding this comment.
The Gemfile needs to be updated with sys/admin (which is already a dependency in puppet)
|
Merged this into stable in commit 46bed4e |
florindragos
pushed a commit
that referenced
this pull request
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The external facts directory always assumed that the user was root, or at
least had read access to the global facts.d directory. This created problems
for users with restricted permissions when running as non-root. Instead of
trying to handle the permissions problem, which would have made facter run,
this changes facter to follow the same non-root style as puppet, which is to
look in the home directory for a .facter/facts.d external facts directory.
Simply handling the error would have had two undesirable consequences: 1) it
would have hidden a problem from the user and 2) it would have made external
facts cumbersome to use as non-root as the user would always have to specify
--external-dir, which is not currently possible when facter is used by
puppet.