(#9546) Do not execute com, cmd, exe, or bat files if not on windows #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Facter currently only executes com, exe, and bat files if on a windows system. It should also exclude these on unix flavored systems since the interpreter for these "cmd.exe" will not be present. This also supports the use of pluginsync for external facts where in a hybrid environment external facts for windows may end up getting syncd to a unix system.
|
CLA signed by all contributors. |
|
Are there cases where someone would see .exe on *nix systems? It's not the convention, but are there any edge cases where it happens? |
|
Or should we be looking at if the particular item has the executable permission? |
|
This will be possible in a hybrid environment where a puppet module tree is used to service both windows and *nix clients. The details can be found in the redmine ticket: https://projects.puppetlabs.com/issues/9546 |
|
Merged into stable as 20a2de6. This should be released in 1.7.4. Thanks again for the contribution! |
florindragos
pushed a commit
that referenced
this pull request
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facter currently only executes com, exe, and bat files if on a windows
system. It should also exclude these on unix flavored systems since
the interpreter for these "cmd.exe" will not be present.
This also supports the use of pluginsync for external facts where in a
hybrid environment external facts for windows may end up getting syncd
to a unix system.