(CPR-5) Move dmidecode from dependency to recommends #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@stahnma if the goal is to make it not arch dependent, arch should be all instead of any |
|
CLA signed by all contributors. |
|
@haus updated |
Previously facter had a hard dependency on dmidecode. This made the debian package uninstallable on ARM based devices such as raspberry pi. This commit moves dmidecode from dependency to recommends. In nearly all cases dmidecode will still be pulled in, unless it can't be (as in the ARM case). This also moves the package from all (meaning any arch it can be built for) to any (meaning noarch). Note this is a packaging change only. Signed-off-by: Michael Stahnke <stahnma@puppetlabs.com>
|
@haus updated again removing arch specifics on the recommends. |
|
👍 |
|
@kylog feel free to merge if you are still 👍 after the recent changes |
|
Should this go on stable rather than master, or do we backport? |
|
@stahnma i think the next facter release planned is 2.2.0, so master is the right place |
|
Can we reference FACT-467 in the commit? May make release notes easier. |
|
Yeah master is fine. We'll be merging down Real Soon Now. |
MikaelSmith
changed the title
MikaelSmith
changed the title
|
Closed in favor of minor changes in #768 |
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously facter had a hard dependency on dmidecode. This made the
debian package uninstallable on ARM based devices such as raspberry pi.
This commit moves dmidecode from dependency to recommends. In nearly all
cases dmidecode will still be pulled in, unless it can't be (as in the
ARM case).
Note this is a packaging change only.
Signed-off-by: Michael Stahnke stahnma@puppetlabs.com