(FACT-825) Increase prtdiag timeout for Solaris virtual fact #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit bumps up the default timeout for the virtual fact in Solaris to 20 seconds. `prtdiag` on large Solaris systems can often take upwards of 10 seconds, so 20 seconds is a reasonably safe timeout. This fix was previously merged (d82f695) and then lost in the Facter-2 / master branch merge.
|
@kylog retargeted! |
|
CLA signed by all contributors. |
|
Can |
|
I'm fine with how we came to the new timeout number (largest seen *2), I'm just curious why it exists in the first place |
|
@adrienthebo You will pay for your lame commit message 😛 @whopper cool, we should probably ticket to add that to cfacter too, then? Unless we've bypassed prtdiag and are just hitting system APIs, in which case it might not matter at all. |
|
I guess since we apparently do need a timeout, I'm 👍 |
MikaelSmith
pushed a commit
that referenced
this pull request
Mar 5, 2015
(FACT-825) Increase prtdiag timeout for Solaris virtual fact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit bumps up the default timeout for the virtual fact in
Solaris to 20 seconds.
prtdiagon large Solaris systems can oftentake upwards of 10 seconds, so 20 seconds is a reasonably safe timeout.
This fix was previously merged (d82f695) and then lost in the
Facter-2 / master branch merge.