Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toml installation: Support install_options #77

Merged
merged 1 commit into from Apr 5, 2023

Conversation

bastelfreak
Copy link
Collaborator

This enables people to pass additional parameters to the gem installation for puppet agent/server. A common usecase is a http proxy.

This enables people to pass additional parameters to the gem
installation for puppet agent/server. A common usecase is a http proxy.
@bastelfreak bastelfreak added the enhancement New feature or request label Mar 30, 2023
@bastelfreak bastelfreak requested a review from a team as a code owner March 30, 2023 09:44
@bastelfreak bastelfreak self-assigned this Mar 30, 2023
@puppet-community-rangefinder
Copy link

influxdb::profile::toml is a class

Breaking changes to this file WILL impact these 1 modules (exact match):

This module is declared in 0 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@m0dular
Copy link
Collaborator

m0dular commented Apr 4, 2023

Thanks @bastelfreak, does this allow for installing .gems locally? So airgapped users could download the toml-rb gem and pass --local <path_to_gem> via the install options? I think that would still leave citrus uninstalled, so maybe we need to add something for that.

@bastelfreak
Copy link
Collaborator Author

The idea was to pass a proxy. If you want to support installation of local gems, I suggest to use the source attribute. The gem provider foro the package resource supports it.

@m0dular
Copy link
Collaborator

m0dular commented Apr 5, 2023

The docs only mention source in the context of remote repositories, so I wasn't sure if that were an option for local gems. Regardless, we can look at that in another PR, this one is good for what it does 👍

@m0dular m0dular merged commit 33c64c1 into puppetlabs:main Apr 5, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants