(SUP-4215) Add creates param to archive resource #81
Conversation
m0dular
force-pushed
the
SUP-4215-archive_version
branch
from
12fb44d
to
4e37d29
Compare
|
can you tell me where the idempotency issue is? I am not aware of any issues in our archive module. |
m0dular
force-pushed
the
SUP-4215-archive_version
branch
from
4e37d29
to
e952bea
Compare
The new version of this module, 6.1.2, includes a fix for ensuring that the cleanup of the archive happens. However, this introduces an idempotency issue unless the creates param is used.
m0dular
force-pushed
the
SUP-4215-archive_version
branch
from
e952bea
to
b7df455
Compare
|
It ended up being that we were not using the |
m0dular
changed the title
| @@ -177,6 +177,7 @@ | |||
| extract => true, | |||
| extract_command => 'tar xfz %s --strip-components=1', | |||
| extract_path => '/opt/influxdb', | |||
| creates => '/opt/influxdb/influxd', | |||
There was a problem hiding this comment.
I think you will have trouble when updating influxdb. The path doesn't contain the version number. When you update the version of influxdb, the creates path won't change and archive won't download the new version. In our prometheus module we always add the version to the path. Adding the version number will also provide a local history of files (when you don't clean it up), which makes rollbacks easier. I think that's something that should be changed in another PR. Vox Pupuli example: https://github.com/voxpupuli/puppet-prometheus/blob/master/manifests/daemon.pp#L108-L134
which will create something like this for the node exporter:
root@voxpupu ~ # tree /opt/node_exporter-1.*
/opt/node_exporter-1.3.1.linux-amd64
├── LICENSE
├── NOTICE
└── node_exporter
/opt/node_exporter-1.4.0.linux-amd64
├── LICENSE
├── NOTICE
└── node_exporter
0 directories, 3 files
root@voxpupu ~ # ls -la /usr/local/bin/node_exporter
lrwxrwxrwx 1 root root 50 Oct 10 2022 /usr/local/bin/node_exporter -> /opt/node_exporter-1.4.0.linux-amd64/node_exporter
root@voxpupu ~ #
There was a problem hiding this comment.
Thanks, I was wondering how upgrades worked with archive sources. Essentially, there should be:
- A versioned directory that the archive is extracted to, e.g.
/opt/influxdb/influxd-2.6.1 - A symlink for the main
influxdbinary that points to the latest archive directory, e.g./usr/local/bin/influxd -> /opt/influxdb/influxd-2.6.1/influxd
Is that about right? I think we would need to make the startup script into a template so that it picks up the right binary. Maybe we should mark this "do not merge" until that is added, or just make a new PR with all of the changes? Although, I'm not sure if upgrading with archive sources works currently unless you delete /opt/influxdb first.
There was a problem hiding this comment.
IMO we should merge this PR, because it fixes the idempotency problem/works with newer puppet/archive version. Fixing the upgrade problem is a different issue. I would not make the startup script a template. When you add the symlink that's fine because /usr/local/bin is usually in $PATH. To be sure, you can update PATH="/opt/influxdb:${PATH}" to PATH="/usr/local/bin:${PATH}" in the script.
There was a problem hiding this comment.
Cool, if someone can approve it I'll merge this PR.
The new version of this module, 6.1.2, includes a fix for ensuring that the cleanup of the archive happens. However, this introduces an idempotency issue where it will always download and cleanup the archive.