Skip to content
This repository has been archived by the owner on Sep 24, 2019. It is now read-only.

(maint) - Adding java_ks to be managed as a Windows module #161

Merged
merged 1 commit into from
Nov 17, 2017

Conversation

pmcmaw
Copy link
Contributor

@pmcmaw pmcmaw commented Nov 15, 2017

Currently java-ks is only listed as a Linux module. It is actually
cross-platform therefore adding Windows to it. This will allow java_ks
to make use of files such as appveyor.yml

Currently java-ks is only listed as a Linux module. It is actually
cross-platform therefore adding Windows to it. This will allow java_ks
to make use of files such as appveyor.yml
@pmcmaw
Copy link
Contributor Author

pmcmaw commented Nov 15, 2017

@glennsarti added you as a reviewer as I would like to get someone with a Windows background to make sure the team is ok with this

@glennsarti
Copy link
Contributor

You may want to do a modsync run on java_ks just to see what happens, as I think this does more than just add appveyor...

@pmcmaw
Copy link
Contributor Author

pmcmaw commented Nov 15, 2017

Ahh cool, I will have a look at that @glennsarti

@pmcmaw
Copy link
Contributor Author

pmcmaw commented Nov 16, 2017

So yeah @glennsarti your right it changes a lot more than adding the appveyor config. The following is also changed:

  1. Gemfile
  2. appveyor.yaml
  3. default nodeset

Closing this PR.

@pmcmaw pmcmaw closed this Nov 16, 2017
@pmcmaw pmcmaw reopened this Nov 16, 2017
@pmcmaw
Copy link
Contributor Author

pmcmaw commented Nov 16, 2017

After going through a 'dry' run, the above config file changes are fine.

Test results in both Appveyor and Travis are not affected and the builds continue to pass with no worrying or significant changes. Reopening and continuing to add to modulesync as long as you have no objections @glennsarti

This is an example of the changes made by modulesync: https://github.com/puppetlabs/puppetlabs-java_ks/pull/202/files

I manually changed the .sync.yml but if we were to go ahead I will get that change put into the module rather than here.

@pmcmaw pmcmaw changed the title (maint) - Adding java_ks to be managed as Windows WIP - Adding java_ks to be managed as Windows Nov 16, 2017
Copy link
Contributor

@glennsarti glennsarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - The title still says WIP otherwise I would've merged.

@pmcmaw pmcmaw changed the title WIP - Adding java_ks to be managed as Windows (maint) - Adding java_ks to be managed as Windows Nov 17, 2017
@pmcmaw pmcmaw changed the title (maint) - Adding java_ks to be managed as Windows (maint) - Adding java_ks to be managed as a Windows module Nov 17, 2017
@david22swan david22swan merged commit ffde6e4 into puppetlabs:master Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants