Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several beaker-related fixes from #104 #105

Merged
merged 4 commits into from
Aug 14, 2018

Conversation

dhollinger
Copy link
Contributor

@dhollinger dhollinger commented Jun 2, 2018

Addresses #104

@DavidS DavidS added the gitlab label Jun 4, 2018
@dhollinger
Copy link
Contributor Author

This superscedes #98 if @cdenneen and @ Odiobill approve

Copy link
Contributor

@cdenneen cdenneen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cdenneen
Copy link
Contributor

cdenneen commented Jun 7, 2018

I've marked 4 of 8 completed in #104
Think there is 1 that really can't be fixed but other 2-3 can probably still be fixed here if want to have everything in one. (While we wait for @Odiobill to approve the custom image changes)

@dhollinger
Copy link
Contributor Author

@cdenneen I'm not sure what the best way to go about setting up the "default" job would look like for beaker. It seems like beaker configs are moving away from that and more to beaker-host-generator instead (at least for Docker jobs). But even then, each user's default job will be potentially unique to them.

Anything we do within this repo should conform to the best practices put forth/expected by Puppetlabs with the ability to be modified as needed by the user. The gitlab-ci.yml, travis.yml, appveyor.yml, etc should all be creating the same jobs as close as possible by default.

@Odiobill
Copy link

Odiobill commented Jun 8, 2018

@cdenneen is there anything else I should do to proceed further?

@cdenneen
Copy link
Contributor

cdenneen commented Jun 8, 2018

@Odiobill do you agree with @dhollinger change for your custom image request? #98

Copy link

@Odiobill Odiobill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree!

Copy link
Contributor

@cdenneen cdenneen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we are good to proceed!

@cdenneen
Copy link
Contributor

CC @DavidS

@cdenneen cdenneen mentioned this pull request Jun 26, 2018
@bmjen
Copy link
Contributor

bmjen commented Jun 26, 2018

CC @npwalker @jarretlavallee

These changes LGTM, but I was hoping you'd take a look to see if any of these gitlab changes would impact you.

Copy link
Contributor

@npwalker npwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A cursory review looks good.

@bmjen bmjen merged commit ed3e719 into puppetlabs:master Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants