-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several beaker-related fixes from #104 #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@cdenneen I'm not sure what the best way to go about setting up the "default" job would look like for beaker. It seems like beaker configs are moving away from that and more to Anything we do within this repo should conform to the best practices put forth/expected by Puppetlabs with the ability to be modified as needed by the user. The |
@cdenneen is there anything else I should do to proceed further? |
@Odiobill do you agree with @dhollinger change for your custom image request? #98 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do agree!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we are good to proceed!
CC @DavidS |
These changes LGTM, but I was hoping you'd take a look to see if any of these gitlab changes would impact you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A cursory review looks good.
Addresses #104