Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PDK_BUNDLE_IGNORE_CONFIG env support #1180

Closed

Conversation

fe80
Copy link

@fe80 fe80 commented Aug 16, 2022

Hello,

For some context that can be useful to define specific bundle configuration for pdk.

Example: In my case I update pdk with pdk docker images and gitlab-ci, but I also add toml as optional for :test group:

Gemfile:
  optional:
    ':test':
      - gem: 'toml'

When I run pdk update, that create a dependency fail. I would like to ignore test group with BUNDLE_WITHOUT, but I can't if BUNDLE_IGNORE_CONFIG is define.

Regards,

@fe80 fe80 requested a review from a team as a code owner August 16, 2022 09:13
@CLAassistant
Copy link

CLAassistant commented Apr 19, 2023

CLA assistant check
All committers have signed the CLA.

@chelnak chelnak self-assigned this Jun 14, 2023
@chelnak
Copy link
Contributor

chelnak commented Jun 14, 2023

Added the blocked label for the time being as this is being discussed internally as a feature request.

@gavindidrichsen
Copy link
Contributor

Hi @fe80.

We've been reviewing our issue backlog and found this. Apologies for the long response time on this!

Are you still interested in progressing this? It seems a good idea. To progress this further, however, we'd need more documentation and testing around the change. We'd then be able to add this to our current docs, etc.

@jordanbreen28
Copy link
Contributor

hey @fe80 we really like this change you've proposed.

For now we are going to set the PR to draft, until you have the bandwidth to pick this back up again and add some unit tests and documentation for the code change.

@jordanbreen28 jordanbreen28 marked this pull request as draft April 12, 2024 10:10
@david22swan
Copy link
Member

@fe80 We are gonna close this PR as unmoving, if you ever find the time to come back to it we will be more than happy to review it again and help you get it across the line.

Have a nice Spring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants