Configure cert.pem for self-hosted git repos #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1362 +/- ##
=======================================
Coverage 88.24% 88.24%
=======================================
Files 128 128
Lines 5435 5435
=======================================
Hits 4796 4796
Misses 639 639 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
gavindidrichsen
force-pushed
the
cat1769_add_to_troubleshooting
branch
from
ccb1995
to
ba1e877
Compare
gavindidrichsen
added
maintenance
gavindidrichsen
force-pushed
the
cat1769_add_to_troubleshooting
branch
2 times, most recently
from
9d65fdb
to
ca0f7b5
Compare
gavindidrichsen
changed the title
The pdk must configure the `/opt/puppetlabs/pdk/ssl/cert.pem` to "trust" self-hosted git repositories. Without this configuration, then the likes of `pdk test unit` will fail with an error `fatal: unable to access...SSL certificate problem: self signed certificate`. This PR adds instruction for the user. In particular, it calls out that updating the version of the pdk will over-write the old customisations. The `/opt/puppetlabs/pdk/ssl/cert.pem` will need to be amended again after the version update. Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
gavindidrichsen
force-pushed
the
cat1769_add_to_troubleshooting
branch
from
a977d3c
to
4f1ac42
Compare
jordanbreen28
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using
pdk test unitone of the actions it performs is to download any module dependencies defined in the.fixtures.yml. If these dependencies are held in self-hosted repositories then pdk'scert.pem1 must be configured to trust the self-hosted server. Otherwise, an error likefatal: unable to access...SSL certificate problem: self signed certificatewill occur when using the PDK, particularly when runningpdk test unit.I've kept the guts of the explanation in the troubleshooting and then linked from related pages (install, upgrade, known issues) to the troubleshooting page.
This PR adds instruction to the docs on how to fix the above and also explains a related known issue: upgrading the PDK will overwrite any previous changes to the
cert.pemChecklist
Footnotes
/opt/puppetlabs/pdk/ssl/cert.pemon linux andC:\Program Files\Puppet Labs\DevelopmentKit\ssl\cert.pemon windows ↩