(PDK-468) new task command
#299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling cff1695 on rodjek:pdk-468 into ** on puppetlabs:tasks**. |
|
Changes Unknown when pulling 8e43f00 on rodjek:pdk-468 into ** on puppetlabs:tasks**. |
bmjen
reviewed
Sep 25, 2017
| name: object_name, | ||
| puppet_task_version: 1, | ||
| supports_noop: true, | ||
| description: options.fetch(:description, 'A short description of this task'), |
There was a problem hiding this comment.
I think we should also have a parameters key here with an empty array, just as a suggestive place to the user of where to go next.
|
Rebased commit: 086e627 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.