(MAINT) Fix issues related to Cri behavior change with options hash #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotje
force-pushed
the
maint_fixup_cri_option_expects
branch
from
ba0fc27
to
f96bf7d
Compare
Apparently this was never the documented Cri behavior and they recently fixed this so that flags and other "no argument" options will have keys set in the options hash with a value of "false" instead of simply being absent from the options hash.
scotje
force-pushed
the
maint_fixup_cri_option_expects
branch
from
f96bf7d
to
dda53e2
Compare
chelnak
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix up test failures and behavior changes related to this change in Cri: denisdefreyne/cri#96