(SUP-2952) (Issue #193) - Retry if provisioning target returns a 500 #194
Conversation
BartoszBlizniak
force-pushed
the
main
branch
2 times, most recently
from
c5a7b2c
to
1b9eb24
Compare
|
Would https://ruby-doc.org/stdlib-2.6.3/libdoc/net/http/rdoc/Net/HTTP.html#method-i-max_retries-3D |
re-try logic with default parameter
|
@BartoszBlizniak if you change the fixtures in one of our test branches in a low priority module, to point to your fork and give it a shot? we should be able to test this |
Fixing string error fixing string conversion error fixing string conversion error fixing string conversion error
|
Hey regarding testing, I have a question, how fast does the The only run that was off by around 30seconds that I managed to get is this one: run of 1m38s https://github.com/puppetlabs/puppetlabs-pe_status_check/runs/6324457998?check_suite_focus=true compared to average 55 seconds: https://github.com/puppetlabs/puppetlabs-pe_status_check/runs/6324451685?check_suite_focus=true In both Ubuntu might be off by around 30s too That said, I've ran around 15 tests and all provisioned successfully so we can assume that the code didn't break any provisioning here. |
Prior to this commit, there was no option to retry the provisioning of an environment which caused the entire workflow to fail, this commit ensures that we try to provision the environment up to 5 times before failing.