Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend puppetfile validation with lingua-pupuli/puppetfile-resolver #198

Closed
jpogran opened this issue Nov 19, 2019 · 0 comments · Fixed by #197
Closed

Extend puppetfile validation with lingua-pupuli/puppetfile-resolver #198

jpogran opened this issue Nov 19, 2019 · 0 comments · Fixed by #197
Assignees
@glennsarti
Milestone
0.23.0

Comments

@jpogran
Copy link
Contributor

jpogran commented Nov 19, 2019

Replace the existing puppetfile validation logic with https://github.com/lingua-pupuli/puppetfile-resolver
@jpogran jpogran added this to the 0.23.0 milestone Nov 19, 2019
@jpogran jpogran added this to To do in 0.22.0 Marketplace Release via automation Nov 19, 2019
@jpogran jpogran mentioned this issue Nov 21, 2019
Closed
@glennsarti glennsarti changed the title Replace puppetfile validation with lingua-pupuli/puppetfile-resolver Extend puppetfile validation with lingua-pupuli/puppetfile-resolver Nov 22, 2019
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Nov 22, 2019
@glennsarti
(puppetlabsGH-198) Revender Molonillo and Puppfile-Resolver
535320b 
The new Puppetfile Resolver gem needs to be revendored, and its dependency
Molonillo. This will be used to Puppetfile module dependency resoltion.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Nov 22, 2019
@glennsarti
(puppetlabsGH-198) Use Puppetfile-resolver with Puppetfile Validation
a19c664 
Previously the Puppetfile validator only performed basic validation checks.
This commit updates the validation to now include doing a full module
dependency resolution based on the validation routines in Puppetfile-Resolver.

This commit also removes the R10K Puppetfile parsing and uses the parser
available in the Puppetfile-Resolver.

By default the resolver is enabled, but can be disabled by setting:

puppet.validate.resolvePuppetfiles: false
@glennsarti glennsarti mentioned this issue Nov 22, 2019
Merged
4 tasks
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Nov 25, 2019
@glennsarti
(puppetlabsGH-198) Revender Molonillo and Puppfile-Resolver
2b111c0 
The new Puppetfile Resolver gem needs to be revendored, and its dependency
Molonillo. This will be used to Puppetfile module dependency resoltion.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Nov 25, 2019
@glennsarti
(puppetlabsGH-198) Use Puppetfile-resolver with Puppetfile Validation
ea8cdeb 
Previously the Puppetfile validator only performed basic validation checks.
This commit updates the validation to now include doing a full module
dependency resolution based on the validation routines in Puppetfile-Resolver.

This commit also removes the R10K Puppetfile parsing and uses the parser
available in the Puppetfile-Resolver.

By default the resolver is enabled, but can be disabled by setting:

puppet.validate.resolvePuppetfiles: false
0.22.0 Marketplace Release automation moved this from To do to Done Nov 27, 2019
jpogran added a commit that referenced this issue Nov 27, 2019
@jpogran
Merge pull request #197 from glennsarti/puppetfile-resolver
2534481 
(GH-198) Use the PuppetFile Resolver for validation
@jpogran jpogran removed this from Done in 0.22.0 Marketplace Release Mar 27, 2020
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Dec 30, 2020
@glennsarti
(puppetlabsGH-198) Reset PuppetLint configuration for each call
c183b7a 
Previously after a call to fix_validation_errors, many validation errors came
in as hints not errors.  This was due to PuppetLint not resetting the
`PuppetLint.configuration.fix` setting between calls.  This commit updates the
validation provider to reset this setting each call.  This commit also adds
tests for this scenario.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glennsarti glennsarti

Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

Successfully merging a pull request may close this issue.

(GH-198) Use the PuppetFile Resolver for validation glennsarti/puppet-editor-services
2 participants
@jpogran @glennsarti