-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend puppetfile validation with lingua-pupuli/puppetfile-resolver #198
Milestone
Comments
glennsarti
added a commit
to glennsarti/puppet-editor-services
that referenced
this issue
Nov 22, 2019
The new Puppetfile Resolver gem needs to be revendored, and its dependency Molonillo. This will be used to Puppetfile module dependency resoltion.
glennsarti
added a commit
to glennsarti/puppet-editor-services
that referenced
this issue
Nov 22, 2019
Previously the Puppetfile validator only performed basic validation checks. This commit updates the validation to now include doing a full module dependency resolution based on the validation routines in Puppetfile-Resolver. This commit also removes the R10K Puppetfile parsing and uses the parser available in the Puppetfile-Resolver. By default the resolver is enabled, but can be disabled by setting: puppet.validate.resolvePuppetfiles: false
4 tasks
glennsarti
added a commit
to glennsarti/puppet-editor-services
that referenced
this issue
Nov 25, 2019
The new Puppetfile Resolver gem needs to be revendored, and its dependency Molonillo. This will be used to Puppetfile module dependency resoltion.
glennsarti
added a commit
to glennsarti/puppet-editor-services
that referenced
this issue
Nov 25, 2019
Previously the Puppetfile validator only performed basic validation checks. This commit updates the validation to now include doing a full module dependency resolution based on the validation routines in Puppetfile-Resolver. This commit also removes the R10K Puppetfile parsing and uses the parser available in the Puppetfile-Resolver. By default the resolver is enabled, but can be disabled by setting: puppet.validate.resolvePuppetfiles: false
jpogran
added a commit
that referenced
this issue
Nov 27, 2019
(GH-198) Use the PuppetFile Resolver for validation
glennsarti
added a commit
to glennsarti/puppet-editor-services
that referenced
this issue
Dec 30, 2020
Previously after a call to fix_validation_errors, many validation errors came in as hints not errors. This was due to PuppetLint not resetting the `PuppetLint.configuration.fix` setting between calls. This commit updates the validation provider to reset this setting each call. This commit also adds tests for this scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Replace the existing puppetfile validation logic with https://github.com/lingua-pupuli/puppetfile-resolver
The text was updated successfully, but these errors were encountered: