Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CAT-1595) - Remove diagnostic on textDoucment onDidClose #356

Merged
merged 2 commits into from
Nov 24, 2023
Merged

(CAT-1595) - Remove diagnostic on textDoucment onDidClose #356

merged 2 commits into from
Nov 24, 2023

Commits on Nov 24, 2023

  1. (CAT-1595) - Remove diagnostic on textDoucment onDidClose 

    Prior to this commit, diagnostics (or "problems") in the vscode problems
pane would not be removed on the closing of a file. This is bad
practice, and quickly leads to a polluted problems pane with linting
issues etc showing for all files despite being open or not.

This commit aims to fix this issue, by calling publishDiagnostics in the
vscode API on the close of a text document with an empty array of
diagnostics as per the vscode documentation.

This has been verified as working in local vscode setup.
    @jordanbreen28
    jordanbreen28 committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    b838eba View commit details
    Browse the repository at this point in the history

  2. (maint) - Rubocop fixes

    @jordanbreen28
    jordanbreen28 committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    23e6ac0 View commit details
    Browse the repository at this point in the history