Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) retrofitting changelog for the last couple of releases #190

Merged
merged 1 commit into from Jul 1, 2019

Conversation

DavidS
Copy link
Contributor

@DavidS DavidS commented Jun 21, 2019

This moves the existing CHANGELOG to HISTORY.md since github_changelog_generator
is not being stable with old CHANGELOG entries.

@DavidS DavidS added the maintenance Maintenance (PDK sync and other maintaining commits) label Jun 21, 2019

- Add `implementations` to reserved bolt keywords [\#165](https://github.com/puppetlabs/puppet-resource_api/pull/165) ([DavidS](https://github.com/DavidS))
- \(MAINT\) Bump version [\#164](https://github.com/puppetlabs/puppet-resource_api/pull/164) ([sebastian-miclea](https://github.com/sebastian-miclea))
- Release prep for v1.8.1 [\#163](https://github.com/puppetlabs/puppet-resource_api/pull/163) ([DavidS](https://github.com/DavidS))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks redundant


**Merged pull requests:**

- \(PA-2496\) Bump version and remove v from version number [\#170](https://github.com/puppetlabs/puppet-resource_api/pull/170) ([mihaibuzgau](https://github.com/mihaibuzgau))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be recorded here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can tag the other's maintenance, but this should really stay, as it is a user-visible change

@DavidS
Copy link
Contributor Author

DavidS commented Jun 21, 2019

Labled a bunch of merged PRs and re-ran the generator

@DavidS
Copy link
Contributor Author

DavidS commented Jun 21, 2019

Cleared out my local github_changelog_generator cache for better results.

This moves the existing CHANGELOG to HISTORY.md since github_changelog_generator
is not being stable with old CHANGELOG entries.
@DavidS
Copy link
Contributor Author

DavidS commented Jul 1, 2019

Rebased on top of current master.

@da-ar da-ar merged commit 55e464b into puppetlabs:master Jul 1, 2019
@DavidS DavidS deleted the retrofit-changelog branch July 1, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (PDK sync and other maintaining commits)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants