Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1644) - Rubocop upgrade to 1.48.1 #335

Merged
merged 27 commits into from
Dec 20, 2023
Merged

Conversation

jordanbreen28
Copy link
Contributor

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 馃煝 Spec tests.
  • 馃煝 Acceptance tests.
  • Manually verified.

@jordanbreen28 jordanbreen28 added the maintenance Maintenance (PDK sync and other maintaining commits) label Dec 19, 2023
@jordanbreen28 jordanbreen28 force-pushed the CAT-1644-rubocop_upgrade branch 3 times, most recently from 3748d0d to b0bf70b Compare December 19, 2023 15:35
@jordanbreen28 jordanbreen28 marked this pull request as ready for review December 20, 2023 11:49
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner December 20, 2023 11:49
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gavindidrichsen gavindidrichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM|!

@gavindidrichsen gavindidrichsen merged commit 8b51d94 into main Dec 20, 2023
8 checks passed
@gavindidrichsen gavindidrichsen deleted the CAT-1644-rubocop_upgrade branch December 20, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (PDK sync and other maintaining commits)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants