(SERVER-251) Tweak jruby-flush tests because of performance issues #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies some of the work previously committed for SERVER-251, mostly due to concerns about the length of execution time added to the suite. 1) The `admin-api-multiple-flush-jruby-pool-test` was eliminated. The value of the test was already a bit dubious due to some of the variable timing in the execution of the test and limited ability to validate the system's behavior with concurrent flush requests. More importantly, the test appeared to add 5 minutes or so to the overall execution time for the test suite - increasing from 6 minutes or so to 11 minutes or so. This commit removes the test completely. 2) The `hold-instance-while-pool-flush-in-progress-test` was modified to just try to initialize 2 `jruby-puppet` instances instead of 4. This should speed the execution of the test up a bit. The test overall may still take around 10 seconds to run; measurements were inconsistent from local runs.
|
+1 |
1 similar comment
|
👍 |
MSLilah
pushed a commit
that referenced
this pull request
Jul 13, 2015
…jruby-flush-tests (SERVER-251) Tweak jruby-flush tests because of performance issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies some of the work previously committed for
SERVER-251, mostly due to concerns about the length of execution time
added to the suite.
The
admin-api-multiple-flush-jruby-pool-testwas eliminated. Thevalue of the test was already a bit dubious due to some of the variable
timing in the execution of the test and limited ability to validate the
system's behavior with concurrent flush requests. More importantly, the
test appeared to add 5 minutes or so to the overall execution time for
the test suite - increasing from 6 minutes or so to 11 minutes or so.
This commit removes the test completely.
The
hold-instance-while-pool-flush-in-progress-testwas modified tojust try to initialize 2
jruby-puppetinstances instead of 4. Thisshould speed the execution of the test up a bit. The test overall may
still take around 10 seconds to run; measurements were inconsistent from
local runs.