(maint) Schemify puppetlabs.puppetserver.testutils #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously these test utilities all did not have schemas applied to them. This commit starts to change that. This introduces schemas to most of the functions and defines a schema for puppet catalogs and resources.
|
👍 I'm into it. Did you file a bug / find out more about that key thing? thanks for doing this! |
|
not yet, planning to still. |
|
👍 thanks for doing this |
jpinsonault
added a commit
that referenced
this pull request
Feb 5, 2016
(maint) Schemify puppetlabs.puppetserver.testutils
|
for posterity, the schema bug was actually just a special case schema has with keywords in maps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously these test utilities all did not have schemas applied to
them. This commit starts to change that. This introduces schemas to most
of the functions and defines a schema for puppet catalogs and resources.