Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects output of resources in Ruby 1.9. #10

Closed
wants to merge 1 commit into from
Closed

Corrects output of resources in Ruby 1.9. #10

wants to merge 1 commit into from

Conversation

aredridel
Copy link

No description provided.

@mmrobins
Copy link
Contributor

Thanks for the patch, but the tests need to pass (http://projects.puppetlabs.com/projects/puppet/wiki/Development_Writing_Tests#Running+Tests) before we can accept it (currently 1 failure in the specs with your change that should be easy to fix), and we generally don't take pull requests from Github. Part of the reason for that is that we need Community License Agreements signed before we accept contributions.

See our Development Lifecycle Wiki for more info if you'd like to contribute: http://projects.puppetlabs.com/projects/puppet/wiki/Development_Development_Lifecycle

We're definitely looking for help on Ruby 1.9 compatibility, so it would be great if you continued to work on that. Currently not all the tests pass under Ruby 1.9, but we need them to continue passing under 1.8.5 and greater.

@mmrobins mmrobins closed this Apr 30, 2011
@aredridel
Copy link
Author

Alright. I can do that.

@mmrobins
Copy link
Contributor

waynr pushed a commit to waynr/puppet that referenced this pull request Jun 9, 2014
Iristyle pushed a commit to Iristyle/puppet that referenced this pull request Sep 9, 2014
Disable SSL verification for http report processor
tampakrap added a commit to tampakrap/puppet that referenced this pull request Feb 5, 2015
Track bootloader (grub2) packages and dependecies
tdevelioglu pushed a commit to tdevelioglu/puppet that referenced this pull request Mar 29, 2016
melissa pushed a commit to melissa/puppet that referenced this pull request Mar 30, 2018
CTH-81 echo request hops in the ping response
melissa pushed a commit to melissa/puppet that referenced this pull request Mar 30, 2018
(maint) Result messages now specify Puppet agent instead of just Puppet
melissa pushed a commit to melissa/puppet that referenced this pull request Mar 30, 2018
(maint) Merge 1.0.x into 1.1.x
luchihoratiu pushed a commit that referenced this pull request Nov 10, 2021
…ization_for_redirects

(PUP-11188) Do not add auth header when redirecting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants