Small fix-ups for unprivileged Puppet runs #1022
Conversation
...and deal with them gracefully without aborting the run.
A simple reproducer of the problem (abort), to be run unprivileged:
puppet apply --execute "file { '/root/chuj': ensure => absent; }"
The user resource itself should fail itself and this prevents falling back to
that. Simple test case (unprivileged):
before$ puppet apply --execute 'user { "kokot": managehome => true }'
Parameter managehome failed: Validate method failed for class managehome: undefined method `manages_homedir?' for NilClass:Class
after$ puppet apply --execute 'user { "kokot": managehome => true }'
err: Could not find a suitable provider for user
notice: Finished catalog run in 0.10 seconds
|
Hi! Is there a ticket for these? And do the tests pass with these changes? Thanks! |
|
Tests do pass. There is no ticket. |
|
@lkundrak, thanks for the submission. Can you open a ticket (or find one that is already open) that describes the problem that this fixes? Ideally it would show the error that you saw and describe what you were trying to do. Once you have that ticket number you can rebase the commits to include the ticket number. This help us and others a lot in understanding what the change does. Once you have that we'll also need to get some tests in place to make sure we don't regress on this functionality. I can help you with that if you need any help. |
|
This has been in stasis for a while. Without any tests to help ensure that we aren't regressing we can't merge this as-is. Once tests have been added, please reopen (or file a new pull req) and we'll take a look! |
I often run puppet --noop unprivileged to conduct a basic sanity check of the recipes (such as checking for duplicate definitions or syntax errors). These changesets fix unnecessary abort that cause puppet to stop way too early.