Issue/23081/report property event for insync exceptions #2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes non-public methods explicitly private. It also reorders the methods to read in a manner where the top is the public and highest level, and it becomes more low level as we move down the file.
This changes removes a large block of unit tests, comprising 1296 individual tests built up via 8 nested 'each' loops. Why remove so many tests? First, in the course of refactoring for #23081 we triggered test failures in this block only when we also triggered a test failure elsewhere, and conversely, it didn't trigger failures where other individual tests did register a useful failure. Second, several people have stared at this unit test block and not been able to figure out what it is uniquely testing. So in short the value of this test block is not clear, so we're removing it. Of course, if we hit future gaps in unit test coverage, we'll add tests back in to cover gaps.
zaphod42
added a commit
that referenced
this pull request
Nov 6, 2013
…-for-insync-exceptions Issue/23081/report property event for insync exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.