(maint) Fix unused argument and variable in file_spec.rb #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,7 +79,7 @@ def spawn_process_that_locks(file) | |||
|
|
|||
| def increment_counter_in_multiple_processes(file, num_procs, options) | |||
| children = [] | |||
| 5.times do |number| | |||
| num_procs.times do |number| | |||
There was a problem hiding this comment.
We can drop the |number| as well since it's unused.
|
Could you prefix your commit message to have |
|
Done and done. |
peterhuene
added a commit
that referenced
this pull request
Jan 14, 2014
(maint) Fix unused argument and variable in file_spec.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this unused argument while working on #2168.