(PUP-2344) Fix issue with inter-module calls (visibility error)

[hlindberg]

This fixes the problem where inter-module function calls could
not be made. The main problem was that a function when loaded
was given the public loader and thus had no visibility into its
containing module's dependencies.

The design is that module resolution should be on-demand, only
when something actually needs the proviate loader should it be resolved.
The resolution is triggered by asking for the private loader, but no
such call was made on the call-path when a function was loaded.

This commit adds the notion of private_loader to the loaders (those that
do not have one respond with self). Those that do either provide the
private loader explicitly (environment loader), or on demand (by
obtaining the private loader from loaders).

This change required tests to be modified since the logic now depends
on :loaders being bound in the Puppet context
logic that made this happen on demand was not implemented

[puppetcla]

CLA signed by all contributors.

[zaphod42]

I found a problem when testing this. It tries to call loader on a LoaderModuleData, which doesn't have that method. In reading through the code to track it down I've built up a bunch of cleanups that I'll send out once I get a fix for the loader problem.

[zaphod42]

Closing in favor of GH-2587