Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PUP-2843) Fix constants on Windows x64 #2809

Conversation

Iristyle
Copy link
Contributor

  • Previous definition in Puppet::Util::Windows::File would work on x86
    but not x64. Adjust the constant, and share the constant with
    Puppet::Util::Windows::Security.

 - Previous definition in Puppet::Util::Windows::File would work on x86
   but not x64.  Adjust the constant, and share the constant with
   Puppet::Util::Windows::Security.
@Iristyle Iristyle changed the title (PUP-2843) Fix INVALID_HANDLE_VALUE on Windows x64 WIP - (PUP-2843) Fix INVALID_HANDLE_VALUE on Windows x64 Jun 25, 2014
@Iristyle Iristyle changed the title WIP - (PUP-2843) Fix INVALID_HANDLE_VALUE on Windows x64 WIP - (PUP-2843) Fix constants on Windows x64 Jun 25, 2014
@Iristyle
Copy link
Contributor Author

Once the PRs have been merged for gem updates / removals, scan the source again and look for definitions of -1 and 0xFFFFFFFF to make sure there isn't anything lingering.

@puppetcla
Copy link

CLA signed by all contributors.

@Iristyle Iristyle changed the title WIP - (PUP-2843) Fix constants on Windows x64 (PUP-2843) Fix constants on Windows x64 Jun 26, 2014
@ferventcoder
Copy link
Contributor

Looks good!

ferventcoder added a commit that referenced this pull request Jun 26, 2014
…Win32-constants

(PUP-2843) Fix constants on Windows x64
@ferventcoder ferventcoder merged commit e2f5389 into puppetlabs:master Jun 26, 2014
@Iristyle Iristyle deleted the ticket/master/PUP-2843-Verify-Win32-constants branch March 1, 2016 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants