(PUP-2886) Add validation for reserved type names #2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this it was possible to name classes and defines with words that are reserved by the type system (e.g. 'integer'), while the name is not a type (Integer is a type, but integer is not), the definitions will automatically create a resource type named with an upper case initial letter, and will thus be difficult to reference. For that reason it is better to error on these names statically.
|
CLA signed by all contributors. |
|
Travis Ruby 1.8.7 took forever and died... rerunning |
jpartlow
added a commit
that referenced
this pull request
Jul 16, 2014
(PUP-2886) Add validation for reserved type names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this it was possible to name classes and defines with
words that are reserved by the type system (e.g. 'integer'), while
the name is not a type (Integer is a type, but integer is not), the
definitions will automatically create a resource type named with
an upper case initial letter, and will thus be difficult to reference.
For that reason it is better to error on these names statically.