(PUP-1186) Ignore PAX header in tar unpacking #2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit if you installed a puppet module built on a platform with a tar implementation that adds PAX headers and your platform didn't have a native tar implementation (Windows), the module would contain junk PaxHeader directories. This is due to the default POSIX behavior programmed in to minitar (the ruby tar implementation used for platforms with out native tar) for an unknown typeflag, such as those used in PAX headers, is to treat it as a regular file and extract it. This commit adds a pre-scan step to our use of minitar for unpacking that finds all the files with standard typeflags (0-7) and then only unpacks those, thus ignoring any Pax typeflags like 'x' or 'g'.
|
CLA signed by all contributors. |
|
I believe this will fly. I tested it before and after the changes, forcing minitar to be used instead of gnutar and saw the errant and then correct behavior. |
andersonmills
added a commit
that referenced
this pull request
Jul 16, 2014
(PUP-1186) Ignore PAX header in tar unpacking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit if you installed a puppet module built on a platform with
a tar implementation that adds PAX headers and your platform didn't have a native
tar implementation (Windows), the module would contain junk PaxHeader directories.
This is due to the default POSIX behavior programmed in to minitar (the ruby tar
implementation used for platforms with out native tar) for an unknown typeflag,
such as those used in PAX headers, is to treat it as a regular file and extract it.
This commit adds a pre-scan step to our use of minitar for unpacking that finds
all the files with standard typeflags (0-7) and then only unpacks those, thus ignoring
any Pax typeflags like 'x' or 'g'.