(PUP-3163) Create and manage the mode of $reportsdir #3036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For redhat and debian, we create and manage a $statedir with ownership set to puppet:puppet. Unfortuntely, we also create a $reportsdir that is owned by root. This means that other applications, even those in the puppet group, could not write to this directory. This commits adds the $reportsdir to both debian and redhat packaging to ensure it is created with the correct permissions (just at the $statedir is), to ensure a more consistent experience for users of our packages.
|
+1 @kylog <3 |
kylog
pushed a commit
that referenced
this pull request
Aug 29, 2014
…r-ownership (PUP-3163) Create and manage the mode of $reportsdir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For redhat and debian, we create and manage a $statedir with ownership
set to puppet:puppet. Unfortuntely, we also create a $reportsdir that is
owned by root. This means that other applications, even those in the
puppet group, could not write to this directory. This commits adds the
$reportsdir to both debian and redhat packaging to ensure it is created
with the correct permissions (just at the $statedir is), to ensure a
more consistent experience for users of our packages.