(PUP-3331) Provide auto* relationships for types #3112
Conversation
|
CLA signed by all contributors. |
| if edge?(edge.target, edge.source) | ||
| vertex.debug "Skipping automatic relationship with #{edge.source}" | ||
| else | ||
| vertex.debug "Forming automation relationshipf of type #{rel_type} with #{edge.source}" |
|
Any chance we can get some specs on this? This looks pretty good so far. |
|
Hi Rob, I'd be happy to add some additional tests. Do you just need each attribute Thanks, Trevor On Wed, Oct 1, 2014 at 2:08 PM, Rob Reynolds notifications@github.com
Trevor Vaughan -- This account not approved for unencrypted proprietary information -- |
|
I'm not sure if we had anything other than autorequire before? It would be nice to get some specs on those new auto* items. Knowing when a relationship happens or doesn't happen. It could help drive some possible behaviors we were not thinking of. |
|
Ok, will work on it as soon as I can. Thanks, Trevor On Thu, Oct 2, 2014 at 3:04 PM, Rob Reynolds notifications@github.com
Trevor Vaughan -- This account not approved for unencrypted proprietary information -- |
|
I'm ready to pull this in. However it looks like it needs to be rebased. Would you like to do that? |
|
Sure thing. I'll work on it tonight if at all possible. Thanks! Trevor On Thu, Oct 16, 2014 at 6:07 PM, Rob Reynolds notifications@github.com
Trevor Vaughan -- This account not approved for unencrypted proprietary information -- |
This patch adds the ability to create all types of auto* relationships for custom types. Supported: * Autorequires * Autonotifies * Autobefore * Autosubscribes Notify and subscribe work properly as designed and can notify services, execs, etc...
Attempted to update the documentation to make it clear that you can now use all four types of relationships. Updates #PUP-3331
Added full spec tests within 'type_spec.rb' for all possible permutations of autorelationships using fake types compiled into a real catalog. This was the only way of ensuring that the propagated events could be properly tested. Updates #PUP-3331
|
Rebased and ready to roll. |
(PUP-3331) Provide auto* relationships for types
|
Thanks for your contribution! This has been merged into master and will be released as part of 4.0.0. |
This patch adds the ability to create all types of auto* relationships
for custom types.
Supported:
Notify and subscribe work properly as designed and can notify services,
execs, etc...