Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PUP-1635) Make daemon.rb signals Ruby 2.x safe #3586

Merged
merged 1 commit into from Feb 25, 2015
Merged

(PUP-1635) Make daemon.rb signals Ruby 2.x safe #3586

merged 1 commit into from Feb 25, 2015

Commits on Feb 23, 2015

  1. (PUP-1635) Make daemon.rb signals Ruby 2.x safe 

    Ruby 2.x changes the way signals work to mean you can't do certain things from the 'trap context'. This means that SIGUSR1 and the like no longer work.

This change makes it so that we, instead of processing methods in the 'trap context', just store them on a list and pop them out the other side in another job called signal_loop.

This is modelled on the way other Ruby Daemon-like projects have fixed this issue.
    @leepa
    leepa committed Feb 23, 2015
    Configuration menu
    Copy the full SHA
    4f8fd24 View commit details
    Browse the repository at this point in the history