I profiled `puppet agent --test` on one of my servers using stackprof
[1] on Ruby 2.1.

Something like 30% or more of the time was spent in
`Puppet::Graph::SimpleGraph#upstream_from_vertex`, called from
`Puppet::Transaction#failed_dependencies?`

It turns out that, while evaluating the resource graph, when considering
a resource, we look at *the complete set of transitive dependencies* to
evaluate whether any of them have failed. This is hugely expensive, and
moreover, is wasted work in the success case where no resources fail.

Instead of all that work, this patch pushes the work to the *failed*
nodes; When a node fails, we transitively walk the dependents of that
node, and mark them as having failed dependencies, and then check that
flag directly when considering whether to skip a node later.

On my test system, this patch drops `puppet agent --test` runtime from
about 40s to about 23s.

[1] https://github.com/tmm1/stackprof

This fixes behavior with dynamically-generated resources, which would
previously not exist during the mark_failed walk, and thus not get
flagged as having failed dependencies.

Add a test case exhibiting the desired behavior, which failed on the
previous commit.

This is to allow it to be shared between the agent and other
applications.

Restore reporting of *which* dependencies have failed when we skip a
resource due to failed dependencies.

This updates the systemd service type to add support for masking. If a
service is masked, it is deemed to also be disabled. If a service is
masked and changed to enabled, it will first be unmasked since the
standard 'systemctl enable' command does not properly unmask the command
first.

The check against the delcared feature is in place so that users do not
have update their code due to differences between systemd and
non-systemd systems.

(PUP-1253) Add systemd service masking support

This change allows puppet to respect the no_proxy ENV var when set on the system.  Previously, Puppet would respect the http(s)_proxy ENV var when connecting HTTP services (e.g. puppetforge) but ignore the no_proxy setting.

Documentation is a bit inconsistent with regards to specifying domain level exception.  WGET docs for example, state that the no_proxy list should be of suffixes and thus an entry with a preceeding '.' (e.g. .example.com) creates an exception for any host under that domain.  Curl man pages and other intenet resources, suggest the use of a '*' as a wildcard.

This change supports both notations.

This change adds an acceptance test to ensure that the 3x forbidden
environment names now work, and continue to work in 4x.
There are 4 previously forbidden names, which means this test has to run
puppet 5 times, unfortunately.

…ceptance_test_that_3_x_forbidden_env_names_work_in_4_x

(PUP-4413) Add acceptance test that 3x forbidden env names work in 4x

Merge Stable to Master

The apply application works by overriding the :current_environment with the
file that was specified on the command line. This had no effect when the node
object (from the ENC) specified an environment of its own.

Remedy this by looking up the node before the environment, favoring its
environment over the configured value and overriding the :manifest of the
chosen one.

…ironments

It was decided that (for the time being) puppet apply should behave
like agent/master when an environment is configured (or specified via
command line argument) and prefer the environment that was returned
by the ENC. A warning to that effect should be displayed to the user.

(The warning is not added through this branch - we had this already.)

(PUP-4517) Add type name to Puppet.newtype deprecation warning

This commit adds a launchd plist for use with OSX AIO packaging.

(PUP-4532) Add launchd plist for use with OSX AIO

Previously, the test was joining the log messages with newlines, and
then testing if the error message matched.

Rspec 3 matchers are composable, so we can assert more directly that
the error message matches one of the log entries.

Rather than rely on executing ruby to manipulate a file to "emulate" a
service start/status/stop command, stub command execution itself to
ensure the base service provider is executing the commands as expected.

Previously, the enc script contained leading whitespace due to the way
ruby handles heredoc.

Shift script contents so there isn't leading whitespace.

* pr/3321:
  (maint) Left justify ENC script
  (maint) Use composable rspec matcher
  (PUP-3341) add tests for the changed behavior
  (PUP-3341) prepare apply spec for non-modulepath related tests of environments
  (maint) prepare apply integration spec for environments
  (PUP-3341) update apply spec test to make ENC specify env
  (PUP-3341) use the proper manifest with puppet apply and ENC

Currently, we allow the user to pass in an empty string for options like
fstype and options. If the user does this, Puppet will create an invalid
entry in the fstab file. We don't want this to happen, since mount will
barf if we allow the invalid entry to be written

Currently, when a user specified a resource to be mounted, puppet allows
the user to not pass in any information for either fstype or options.
This was fine if there was an existing entry for that resource defined
in fstab, but if this was for a new entry then it would create an
invalid entry. Then when mount was called against the fstab file, mount
would barf everywhere.

This commit updates how we deal with updating the fstab file:

* Options omitted
  - Creating a new entry:
    * linux; `:options => 'defaults'`
    * non-linux; raise Puppet::Error
  - Updating an existing entry:
    * Existing entry options set to 'something,valid'; `:options => 'something,valid'`
    * Existing entry options not set
      - linux; `:options => 'defaults'`
      - non-linux; raise Puppet::Error
* fstype omitted
  - Creating a new entry; raise Puppet::Error
  - Updating an existing entry:
    * Existing entry fstype set to 'ext3'; `fstype => 'ext3'`
    * Existing entry fstype not set; raise Puppet::Error

(PUP-4210) Add rename to augeas

(PUP-4030) Support no_proxy env variable

* upstream/pr/3892:
  (PUP-4524) Stub command execution in base service provider spec.

A require for `puppet/util/http_proxy` was missing for
`puppet/network/http/factory` after code that uses
Puppet::Util::HttpProxy was added.

This originally passed specs because the spec required the file before
using the HTTP factory.

(PUP-4030) Add missing require for Puppet::Util::HttpProxy.

We already test that when a resource fails, we don't apply resources
that (recursively) depend on it. Add some more tests that verify that
we're propagating internal state correctly as we do so.

(PUP-4347) Add test for the File resource ignore attribute

(PUP-1931) Fix mount provider failure w/o options

(PUP-3930) Optimize `failed_dependencies?`

In FACT-956, the ruby facter component was removed from
puppet-agent#master, and cfacter was renamed to facter. As a result,
there are no longer files named cfacter.

This commit updates the acceptance test to no longer check for cfacter.

…onger

(maint) CFacter is no longer in puppet-agent master

The ENC integration tests using the exec terminus were originally only
implemented with shell scripts. Extend the testing to create Windows batch
scripts and run on Windows.

Also create a new spec_helper script_containing to generate a script on
the appropriate platform. Since script languages also differ, usage
requires that you provide both Windows and shell versions of the script.

Document what happens with stderr output if combine is false
and correct the default value for squelch

(docs) fixing documentation for Puppet::Util::Execution

* upstream/pr/3899:
  (PUP-4473) Extend ENC tests to Windows

Ticket ref: PUP-4530

This change adds a test for all parser functions.
This test calls all the parser functions that ship with puppet.  It
ensures sane output in most cases.  The remainder of the coverage for
functions lies in the spec tests.

Take just the leading string of non-whitespace characters
from the first line of the rcvar output as the service name

(PUP-4363) Support splay in apply as well

…alling_all_parser_functions

(PUP-4342) test calling all parser functions; failing spec tests are unrelated to this commit.

this change removes an acceptance test which only exercises an apply
manifest using the File resource which is even better tested elsewhere

Commit e1c8724 resolved a conflict
in defaults.rb that re-introduced the stringify_facts,
trusted_node_data, and immutable_node_data settings that were removed in
4.0.

This commit removes them again.

…urious_test

(maint) remove spurious test

This will prevent gem upgrade on environments with ruby 1.8.7

(maint) Fix bad merge from 3.x branch.

(PUP-4601) Add ruby version requirement to .gemspec.

* upstream/stable:
  (PUP-4436) Generate error message in eventlog differently

Take just the leading string of non-whitespace characters from the
first line of the rcvar output as the service name